Changeset 326 for binary-improvements/MapRendering/Web/WebConnection.cs

Timestamp:

Sep 4, 2018, 2:33:52 PM (6 years ago)

Author:

alloc

Message:

More cleanup, allocation improvements

File:

• binary-improvements/MapRendering/Web/WebConnection.cs (modified) (4 diffs)

binary-improvements/MapRendering/Web/WebConnection.cs

@@ -6 +6 @@
         public class WebConnection : ConsoleConnectionAbstract {
                 private readonly DateTime login;
-                private readonly List<string> outputLines = new List<string> ();
+//              private readonly List<string> outputLines = new List<string> ();
                 private DateTime lastAction;
                 private readonly string conDescription;
@@ -30 +30 @@
 
                 public static bool CanViewAllPlayers (int _permissionLevel) {
-                        bool val = false;
+                        const int defaultPermissionLevel = 0;
 
-                        try {
-                                const int defaultPermissionLevel = 0;
+                        bool val = _permissionLevel <= defaultPermissionLevel;
 
-                                val = _permissionLevel <= defaultPermissionLevel;
-
-                                foreach (WebPermissions.WebModulePermission wap in WebPermissions.Instance.GetModules ()) {
-                                        if (wap.module.Trim ().ToLower () == "webapi.viewallplayers") {
-                                                val = _permissionLevel <= wap.permissionLevel;
-                                        }
+                        foreach (WebPermissions.WebModulePermission wap in WebPermissions.Instance.GetModules ()) {
+                                if (wap.module.EqualsCaseInsensitive ("webapi.viewallplayers")) {
+                                        val = _permissionLevel <= wap.permissionLevel;
                                 }
-                        } catch {
                         }
 
@@ -49 +44 @@
 
                 public static bool CanViewAllClaims (int _permissionLevel) {
-                        bool val = false;
+                        const int defaultPermissionLevel = 0;
 
-                        try {
-                                const int defaultPermissionLevel = 0;
+                        bool val = _permissionLevel <= defaultPermissionLevel;
 
-                                val = _permissionLevel <= defaultPermissionLevel;
-
-                                foreach (WebPermissions.WebModulePermission wap in WebPermissions.Instance.GetModules ()) {
-                                        if (wap.module.Trim ().ToLower () == "webapi.viewallclaims") {
-                                                val = _permissionLevel <= wap.permissionLevel;
-                                        }
+                        foreach (WebPermissions.WebModulePermission wap in WebPermissions.Instance.GetModules ()) {
+                                if (wap.module.EqualsCaseInsensitive ("webapi.viewallclaims")) {
+                                        val = _permissionLevel <= wap.permissionLevel;
                                 }
-                        } catch {
                         }
 
@@ -76 +66 @@
 
                 public override void SendLine (string _text) {
-                        outputLines.Add (_text);
+//                      outputLines.Add (_text);
                 }
 
                 public override void SendLines (List<string> _output) {
-                        outputLines.AddRange (_output);
+//                      outputLines.AddRange (_output);
                 }