Changeset 359 for binary-improvements/AllocsCommands/Commands/ListItems.cs

Timestamp:

Oct 29, 2019, 11:20:45 AM (5 years ago)

Author:

alloc

Message:

Removed unnecessary try-catch-blocks from commands (command handler catches exceptions anyway and provides more detailed output)

File:

• binary-improvements/AllocsCommands/Commands/ListItems.cs (modified) (1 diff)

binary-improvements/AllocsCommands/Commands/ListItems.cs

@@ -22 +22 @@
 
                 public override void Execute (List<string> _params, CommandSenderInfo _senderInfo) {
-                        try {
-                                if (_params.Count != 1 || _params [0].Length == 0) {
-                                        SdtdConsole.Instance.Output ("Usage: listitems <searchString>");
-                                        return;
+                        if (_params.Count != 1 || _params [0].Length == 0) {
+                                SdtdConsole.Instance.Output ("Usage: listitems <searchString>");
+                                return;
+                        }
+
+                        int count = ItemClass.ItemNames.Count;
+                        bool showAll = _params [0].Trim ().Equals ("*");
+
+                        int listed = 0;
+                        for (int i = 0; i < count; i++) {
+                                string s = ItemClass.ItemNames [i];
+                                if (showAll || s.IndexOf (_params [0], StringComparison.OrdinalIgnoreCase) >= 0) {
+                                        SdtdConsole.Instance.Output ("    " + s);
+                                        listed++;
                                 }
+                        }
 
-                                int count = ItemClass.ItemNames.Count;
-                                bool showAll = _params [0].Trim ().Equals ("*");
-
-                                int listed = 0;
-                                for (int i = 0; i < count; i++) {
-                                        string s = ItemClass.ItemNames [i];
-                                        if (showAll || s.IndexOf (_params [0], StringComparison.OrdinalIgnoreCase) >= 0) {
-                                                SdtdConsole.Instance.Output ("    " + s);
-                                                listed++;
-                                        }
-                                }
-
-                                SdtdConsole.Instance.Output ("Listed " + listed + " matching items.");
-                        } catch (Exception e) {
-                                Log.Out ("Error in ListItems.Run: " + e);
-                        }
+                        SdtdConsole.Instance.Output ("Listed " + listed + " matching items.");
                 }
         }