Changeset 433 for binary-improvements2/WebServer/src/UrlHandlers/SessionHandler.cs

Timestamp:

May 7, 2023, 5:05:29 PM (19 months ago)

Author:

alloc

Message:

Fixed: User registration allowed same username for multiple users

File:

• binary-improvements2/WebServer/src/UrlHandlers/SessionHandler.cs (modified) (2 diffs)

binary-improvements2/WebServer/src/UrlHandlers/SessionHandler.cs

@@ -90 +90 @@
                         }
 
-                        AdminWebUsers.WebUser? webUser = AdminWebUsers.Instance.GetUser (username, password);
-
-                        if (!webUser.HasValue) {
+                        if (!AdminWebUsers.Instance.TryGetUser (username, password, out AdminWebUsers.WebUser webUser)) {
                                 Log.Out ($"[Web] User/pass login failed from {_remoteEndpointString}");
                                 WebUtils.WriteText (_context.Response, "UserPassInvalid", HttpStatusCode.Unauthorized);
@@ -98 +96 @@
                         }
 
-                        HandleUserIdLogin (connectionHandler, _context, _remoteEndpointString, userPassLoginName, userPassErrorPage, webUser.Value.Name, webUser.Value.PlatformUser, webUser.Value.CrossPlatformUser);
+                        HandleUserIdLogin (connectionHandler, _context, _remoteEndpointString, userPassLoginName, userPassErrorPage, webUser.Name, webUser.PlatformUser, webUser.CrossPlatformUser);
                 }