Changeset 455 for binary-improvements/MapRendering/API/GetPlayerInventories.cs

Timestamp:

Jul 31, 2023, 4:06:13 PM (16 months ago)

Author:

alloc

Message:

25_30_44

• Got rid (mostly) of custom JSON serialization
• Some code cleanup

File:

• binary-improvements/MapRendering/API/GetPlayerInventories.cs (modified) (2 diffs)

binary-improvements/MapRendering/API/GetPlayerInventories.cs

@@ -1 +1 @@
 using System.Collections.Generic;
-using AllocsFixes.JSON;
 using AllocsFixes.PersistentData;
+using JetBrains.Annotations;
+using Utf8Json;
 using Webserver;
 using Webserver.WebAPI;
 
 namespace AllocsFixes.WebAPIs {
+        [UsedImplicitly]
         public class GetPlayerInventories : AbsWebAPI {
                 public override void HandleRequest (RequestContext _context) {
                         GetPlayerInventory.GetInventoryArguments (_context, out bool showIconColor, out bool showIconName);
 
-                        JSONArray AllInventoriesResult = new JSONArray ();
+                        JsonWriter writer = new JsonWriter ();
+                        
+                        writer.WriteBeginArray ();
+                        
+                        bool first = true;
 
                         foreach (KeyValuePair<PlatformUserIdentifierAbs, Player> kvp in PersistentContainer.Instance.Players.Dict) {
@@ -20 +26 @@
 
                                 if (p.IsOnline) {
-                                        AllInventoriesResult.Add (GetPlayerInventory.DoPlayer (p, showIconColor, showIconName));
+                                        if (!first) {
+                                                writer.WriteValueSeparator ();
+                                        }
+
+                                        first = false;
+                                
+                                        GetPlayerInventory.DoPlayer (ref writer, p, showIconColor, showIconName);
                                 }
                         }
-
-                        LegacyApiHelper.WriteJSON (_context.Response, AllInventoriesResult);
+                        
+                        writer.WriteEndArray ();
+                        
+                        WebUtils.WriteJsonData (_context.Response, ref writer);
                 }
         }