Changeset 326 for binary-improvements/7dtd-server-fixes/src/PersistentData/Player.cs

Timestamp:

Sep 4, 2018, 2:33:52 PM (6 years ago)

Author:

alloc

Message:

More cleanup, allocation improvements

File:

• binary-improvements/7dtd-server-fixes/src/PersistentData/Player.cs (modified) (2 diffs)

binary-improvements/7dtd-server-fixes/src/PersistentData/Player.cs

@@ -174 +174 @@
 
                 public void SetOffline () {
-                        if (clientInfo != null) {
-                                Log.Out ("Player set to offline: " + steamId);
-                                lastOnline = DateTime.Now;
-                                try {
-                                        Vector3i lastPos = new Vector3i (Entity.GetPosition ());
-                                        lastPositionX = lastPos.x;
-                                        lastPositionY = lastPos.y;
-                                        lastPositionZ = lastPos.z;
-                                        totalPlayTime += (long) (Time.timeSinceLevelLoad - Entity.CreationTimeSinceLevelLoad);
-                                } catch (NullReferenceException) {
-                                        Log.Out ("Entity not available. Something seems to be wrong here...");
-                                }
-
-                                clientInfo = null;
-                        }
+                        if (clientInfo == null) {
+                                return;
+                        }
+
+                        Log.Out ("Player set to offline: " + steamId);
+                        lastOnline = DateTime.Now;
+                        try {
+                                Vector3i lastPos = new Vector3i (Entity.GetPosition ());
+                                lastPositionX = lastPos.x;
+                                lastPositionY = lastPos.y;
+                                lastPositionZ = lastPos.z;
+                                totalPlayTime += (long) (Time.timeSinceLevelLoad - Entity.CreationTimeSinceLevelLoad);
+                        } catch (NullReferenceException) {
+                                Log.Out ("Entity not available. Something seems to be wrong here...");
+                        }
+
+                        clientInfo = null;
                 }
 
@@ -206 +208 @@
 
                 private void UpdateProgression (PlayerDataFile _pdf) {
-                        if (_pdf.progressionData.Length > 0) {
-                                using (PooledBinaryReader pbr = MemoryPools.poolBinaryReader.AllocSync (false)) {
-                                        pbr.SetBaseStream (_pdf.progressionData);
-                                        Progression p = Progression.Read (pbr, null);
-                                        expToNextLevel = (uint) p.ExpToNextLevel;
-                                        level = p.Level;
-                                }
+                        if (_pdf.progressionData.Length <= 0) {
+                                return;
+                        }
+
+                        using (PooledBinaryReader pbr = MemoryPools.poolBinaryReader.AllocSync (false)) {
+                                pbr.SetBaseStream (_pdf.progressionData);
+                                Progression p = Progression.Read (pbr, null);
+                                expToNextLevel = (uint) p.ExpToNextLevel;
+                                level = p.Level;
                         }
                 }